Conversation
piaskowyk
approved these changes
Mar 27, 2024
Co-authored-by: Krzysztof Piaskowy <[email protected]>
piaskowyk
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for cloning JS
Errorinstances from RN runtime to UI runtime (or any worklet runtime).The copied error inherits the original name, message as well as stack trace.
Initially, I also wanted to implement cloning in the opposite direction (UI → RN) but currently
makeShareableCloneOnUIRecursivedoes not support initializers and most likely will be subject to change as we plan to unify the implementation of cloning across the runtimes.Test plan
ShareableExample.tsx